-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs and example showing how to get the expression data type #9118
Conversation
…ssion Signed-off-by: Nikolay Ulmasov <[email protected]>
Ignore this comment, found another way |
Signed-off-by: Nikolay Ulmasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @r3stl355 -- this looks great ❤️ . It will be very helpful
I had some small suggestions but I also think we could do them as follow on PRs (or never)
@alamb I'll make these changes later today, this is not merged yet so I don't see a reason for not implementing them Update: I made all the suggested changes |
Signed-off-by: Nikolay Ulmasov <[email protected]>
Thanks again @r3stl355 |
Which issue does this PR close?
Closes #7725
Rationale for this change
Make it easier to understand what the
get_type
returnsWhat changes are included in this PR?
Are these changes tested?
An extra example in
datafusion-examples/examples/expr_api.rs
Docscring in
datafusion/expr/src/expr_schema.rs
A paragraph in
docs/source/library-user-guide/working-with-exprs.md
Are there any user-facing changes?
Only documentation and an example, no breaking changes