Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematic Configuration in 'Create External Table' and 'Copy To' Options #9382

Merged
merged 35 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
0f176a1
Initial but not completely work like proto
metesynnada Feb 15, 2024
10000fb
Delete docs.yaml
metesynnada Feb 22, 2024
6c76423
Merge pull request #5 from synnada-ai/ci-action-fixing
mustafasrepo Feb 22, 2024
599516b
Merge branch 'apache:main' into main
mustafasrepo Feb 23, 2024
b20b65c
Merge branch 'apache:main' into main
mustafasrepo Feb 26, 2024
cac943d
Before proto is handled
metesynnada Feb 26, 2024
3fba4a0
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Feb 26, 2024
c17d655
Update listing_table_factory.rs
metesynnada Feb 26, 2024
13e7e83
Before proto 2
metesynnada Feb 26, 2024
25d5685
Minor adjustments
metesynnada Feb 26, 2024
14ed29f
Merge branch 'main' into configuration
metesynnada Feb 26, 2024
daca94e
Update headers
mustafasrepo Feb 27, 2024
0e1300d
Update copy.slt
metesynnada Feb 27, 2024
c2da778
Merge branch 'configuration' of https://github.com/synnada-ai/datafus…
mustafasrepo Feb 27, 2024
ea22682
Add new test,
mustafasrepo Feb 27, 2024
fb86d94
Passes SLT tests
metesynnada Feb 27, 2024
b89b138
Update csv.rs
metesynnada Feb 28, 2024
33eca8d
Before trying char
metesynnada Feb 28, 2024
3caf33e
Fix u8 handling
metesynnada Feb 28, 2024
d16bb65
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Feb 29, 2024
4f1acf1
Update according to review
metesynnada Feb 29, 2024
036f005
Passing tests
metesynnada Mar 5, 2024
ba938a9
passing tests with proto
metesynnada Mar 5, 2024
cff6bc9
Cargo fix
metesynnada Mar 5, 2024
2fd3c4e
Testing and clippy refactors
metesynnada Mar 6, 2024
f141345
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Mar 6, 2024
55a223c
After merge corrections
metesynnada Mar 6, 2024
7dfa7ee
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Mar 6, 2024
4f9acdf
Parquet feature fix
metesynnada Mar 6, 2024
b0bb337
On datafusion-cli register COPY statements
metesynnada Mar 7, 2024
00525a8
Correcting a test
metesynnada Mar 7, 2024
f2f1d96
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Mar 7, 2024
129e682
Review
ozankabak Mar 11, 2024
9f06c6f
Review visited
metesynnada Mar 12, 2024
e27dfe8
Merge remote-tracking branch 'upstream/main' into configuration
metesynnada Mar 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 0 additions & 64 deletions .github/workflows/docs.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion benchmarks/src/tpch/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ impl RunOpt {
}
"parquet" => {
let path = format!("{path}/{table}");
let format = ParquetFormat::default().with_enable_pruning(Some(true));
let format = ParquetFormat::default().with_enable_pruning(true);

(Arc::new(format), path, DEFAULT_PARQUET_EXTENSION)
}
Expand Down
14 changes: 0 additions & 14 deletions datafusion-cli/src/exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,20 +314,6 @@ mod tests {

if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut plan {
create_external_table(&ctx, cmd).await?;
let options: Vec<_> = cmd
.options
.iter()
.map(|(k, v)| (k.clone(), v.clone()))
.collect();
let statement_options = StatementOptions::new(options);
let file_type =
datafusion_common::FileType::from_str(cmd.file_type.as_str())?;

let _file_type_writer_options = FileTypeWriterOptions::build(
&file_type,
ctx.state().config_options(),
&statement_options,
)?;
} else {
return plan_err!("LogicalPlan is not a CreateExternalTable");
}
Expand Down
1 change: 1 addition & 0 deletions datafusion-examples/examples/dataframe_output.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ async fn main() -> Result<(), DataFusionError> {
.write_json(
"./datafusion-examples/test_json/",
DataFrameWriteOptions::new(),
None,
)
.await?;

Expand Down
2 changes: 1 addition & 1 deletion datafusion-examples/examples/parquet_sql_multiple_files.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
let test_data = datafusion::test_util::parquet_test_data();

// Configure listing options
let file_format = ParquetFormat::default().with_enable_pruning(Some(true));
let file_format = ParquetFormat::default().with_enable_pruning(true);
let listing_options = ListingOptions::new(Arc::new(file_format))
// This is a workaround for this example since `test_data` contains
// many different parquet different files,
Expand Down
Loading
Loading