Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-1986]optimize redis connection release #1987

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

ningyu1
Copy link
Contributor

@ningyu1 ningyu1 commented Jun 26, 2018

What is the purpose of the change

Secure release of redis connections #1986

Brief changelog

Secure release of redis connections

Verifying this change

RedisProtocol.java

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #1987 into master will decrease coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1987      +/-   ##
============================================
- Coverage     50.84%   50.82%   -0.03%     
+ Complexity     4769     4764       -5     
============================================
  Files           562      562              
  Lines         25218    25218              
  Branches       4449     4449              
============================================
- Hits          12822    12816       -6     
- Misses        10466    10467       +1     
- Partials       1930     1935       +5
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/protocol/redis/RedisProtocol.java 60% <87.5%> (ø) 6 <0> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-6.25%) 21% <0%> (-2%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-4.17%) 3% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88.88% <0%> (+5.55%) 7% <0%> (+1%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 48.38% <0%> (+19.35%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee0be3...13b233f. Read the comment docs.

@beiwei30 beiwei30 merged commit 7a48fac into apache:master Jun 26, 2018
@ningyu1 ningyu1 deleted the fix-jedis branch November 5, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants