bugfix init reference dead lock #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
============================================
- Coverage 53.05% 53.03% -0.03%
+ Complexity 4953 4951 -2
============================================
Files 559 559
Lines 24892 24894 +2
Branches 4431 4432 +1
============================================
- Hits 13207 13202 -5
- Misses 9662 9667 +5
- Partials 2023 2025 +2
Continue to review full report at Codecov.
|
beiwei30
requested changes
Jul 11, 2018
|
|
||
| //SPI never get from spring bean factory | ||
| if (type.isInterface() && type.isAnnotationPresent(SPI.class)) { | ||
| ExtensionLoader<T> loader = ExtensionLoader.getExtensionLoader(type); |
There was a problem hiding this comment.
in this case, we should simply return null since it is SpiExtensionFactory's duty.
There was a problem hiding this comment.
you are right, it's not SpringExtensionFactory's duty to find SPI instance.
|
The code has been modified, please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#2052 dubbo 整合spring boot 的时候死锁，
Brief changelog
dubbo-config/dubbo-config-spring/org/apache/dubbo/config/spring/extension/SpringExtensionFactory
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.