Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo-1929]: remove the verison property that is no use (#1929) #2078

Merged
merged 1 commit into from
Jul 13, 2018
Merged

[dubbo-1929]: remove the verison property that is no use (#1929) #2078

merged 1 commit into from
Jul 13, 2018

Conversation

luyuanwan
Copy link
Contributor

remove the verison property that is no use, you can see issue #1929

@codecov-io
Copy link

Codecov Report

Merging #2078 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2078      +/-   ##
============================================
- Coverage     53.06%   52.95%   -0.12%     
- Complexity     4956     5004      +48     
============================================
  Files           559      570      +11     
  Lines         24894    25552     +658     
  Branches       4432     4492      +60     
============================================
+ Hits          13211    13530     +319     
- Misses         9661     9967     +306     
- Partials       2022     2055      +33
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.25% <0%> (-5%) 22% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 46.97% <0%> (-0.72%) 38% <0%> (ø)
...e/dubbo/rpc/protocol/thrift/ThriftNativeCodec.java 0% <0%> (ø) 0% <0%> (?)
...rpc/protocol/thrift/ext/MultiServiceProcessor.java 12.76% <0%> (ø) 3% <0%> (?)
...o/rpc/protocol/thrift/DubboClassNameGenerator.java 100% <0%> (ø) 3% <0%> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7a9cc...88ebe97. Read the comment docs.

@ralf0131
Copy link
Contributor

Looks good to me! Thanks for the pull request!

@ralf0131 ralf0131 merged commit cd68437 into apache:master Jul 13, 2018
@luyuanwan luyuanwan deleted the fix1929 branch July 14, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants