Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2088 Miss context path when export a rest service explicitly #2092

Merged
merged 4 commits into from
Jul 18, 2018

Conversation

kimmking
Copy link
Member

What is the purpose of the change

fix #2088 Miss context path when export a rest service explicitly

Brief changelog

fix #2088 Miss context path when export a rest service explicitly

Verifying this change

test cases

@codecov-io
Copy link

Codecov Report

Merging #2092 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2092      +/-   ##
============================================
- Coverage     53.05%   53.04%   -0.01%     
+ Complexity     4957     4954       -3     
============================================
  Files           559      559              
  Lines         24894    24894              
  Branches       4432     4432              
============================================
- Hits          13207    13206       -1     
+ Misses         9667     9666       -1     
- Partials       2020     2022       +2
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 65.57% <60%> (ø) 15 <2> (ø) ⬇️
...apache/dubbo/rpc/protocol/rest/BaseRestServer.java 88.88% <0%> (-11.12%) 7% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-2.54%) 11% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 50% <0%> (+8.33%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56f48...9785e17. Read the comment docs.

@lovepoem lovepoem merged commit 0513b06 into apache:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Miss context path when export a rest service explicitly
3 participants