Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo - unit test coverage] dubbo-common Unit test coverage #2094

Merged
merged 4 commits into from
Jul 18, 2018

Conversation

zonghaishang
Copy link
Member

What is the purpose of the change

unit test coverage, refer: #1680

Brief changelog

dubbo-common(beanutil & bytecode & compiler & extension).

Verifying this change

ci passed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2094 into master will increase coverage by 1.1%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2094     +/-   ##
===========================================
+ Coverage     53.05%   54.15%   +1.1%     
- Complexity     4957     5077    +120     
===========================================
  Files           559      559             
  Lines         24894    24905     +11     
  Branches       4432     4438      +6     
===========================================
+ Hits          13207    13487    +280     
+ Misses         9667     9382    -285     
- Partials       2020     2036     +16
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 79.38% <ø> (+6.52%) 86 <0> (+18) ⬆️
...apache/dubbo/common/extension/ExtensionLoader.java 72.7% <100%> (+0.05%) 116 <1> (ø) ⬇️
...g/apache/dubbo/common/bytecode/ClassGenerator.java 59% <42.85%> (+4.57%) 46 <2> (+3) ⬆️
...ache/dubbo/common/compiler/support/ClassUtils.java 52.97% <87.5%> (+52.97%) 61 <0> (+61) ⬆️
...ubbo/common/compiler/support/AdaptiveCompiler.java 77.77% <0%> (-11.12%) 3% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.25% <0%> (-5%) 21% <0%> (-2%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-2.54%) 11% <0%> (-1%)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.16% <0%> (+0.83%) 31% <0%> (+1%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56f48...e3d947e. Read the comment docs.

@lovepoem
Copy link
Member

Look good to me

@lovepoem lovepoem merged commit 040be91 into apache:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants