Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs in AsyncContext #2101

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Docs in AsyncContext #2101

merged 1 commit into from
Jul 20, 2018

Conversation

carryxyh
Copy link
Member

  • Docs in AsyncContext
  • Make the future final which is in the constructor of AsyncRpcResult because of using in a inner class.

* Make the future final which is in the constructor of AsyncRpcResult because of using in a inner class.
@codecov-io
Copy link

Codecov Report

Merging #2101 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2101      +/-   ##
============================================
- Coverage     54.13%   54.11%   -0.03%     
+ Complexity     5080     5077       -3     
============================================
  Files           559      559              
  Lines         24908    24908              
  Branches       4438     4438              
============================================
- Hits          13485    13478       -7     
- Misses         9388     9391       +3     
- Partials       2035     2039       +4
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 46.97% <0%> (-0.72%) 38% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4ea54...bed69b8. Read the comment docs.

@ralf0131
Copy link
Contributor

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit e22d18c into apache:master Jul 20, 2018
@carryxyh carryxyh deleted the feature/docs branch July 21, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants