Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-5104] fix add mvn dependency to dubbo-all #5104

Closed
wants to merge 1 commit into from

Conversation

vio-lin
Copy link
Contributor

@vio-lin vio-lin commented Sep 23, 2019

What is the purpose of the change

see pull request #4408
It move code and do not add maven dependency to dubbo-all/pom.xml

Brief changelog

add maven dependency to dubbo-all/pom.xml

dubbo\dubbo-all\pom.xml

Verifying this change

add maven dependency

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@vio-lin vio-lin changed the title Dubbo-XXX fix add mvn dependency to dubbo-all [Dubbo-5104] fix add mvn dependency to dubbo-all Sep 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #5104 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5104      +/-   ##
============================================
- Coverage     64.03%   64.02%   -0.02%     
- Complexity      453      480      +27     
============================================
  Files           769      770       +1     
  Lines         33263    33358      +95     
  Branches       5250     5271      +21     
============================================
+ Hits          21301    21358      +57     
- Misses         9524     9554      +30     
- Partials       2438     2446       +8
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
...pache/dubbo/remoting/transport/AbstractServer.java 44.79% <0%> (-3.13%) 0% <0%> (ø)
...dubbo/metadata/support/AbstractMetadataReport.java 72.83% <0%> (-1.74%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (-0.94%) 16% <0%> (-1%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
...adata/definition/protobuf/ProtobufTypeBuilder.java 70.52% <0%> (ø) 28% <0%> (?)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.44% <0%> (+0.28%) 32% <0%> (+1%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d09ef9...e70026e. Read the comment docs.

@vio-lin vio-lin closed this Sep 24, 2019
@vio-lin vio-lin deleted the add-maven0dependency branch September 28, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants