Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-9071] MDT validator can configure if log truncation applies #12877

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Davis-Zhang-Onehouse
Copy link
Contributor

@Davis-Zhang-Onehouse Davis-Zhang-Onehouse commented Feb 24, 2025

bump up unit test coverage

Change Logs

MDT validator should be configurable on if log truncation is required. Otherwise, we might stuck in a situation where we could not get the full list of mismatches at all.

Now to avoid truncation, just give a none positive value to --log-detail-max-length option. By default it uses value 1e5.

Impact

Better operation experience when using this utility.

Risk level (write none, low medium or high below)

none

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Feb 24, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@Davis-Zhang-Onehouse
Copy link
Contributor Author

Azure CI failure is irrelevant

@nsivabalan
Copy link
Contributor

@Davis-Zhang-Onehouse : can you check CI failure

@nsivabalan
Copy link
Contributor

image

@nsivabalan nsivabalan merged commit 8b1a565 into apache:master Feb 25, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants