Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: optimizing the error returns in the seataserver controller #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Iceber
Copy link
Contributor

@Iceber Iceber commented May 30, 2024

Minimizing the use of elseif / else will make the code clearer

@Iceber Iceber force-pushed the optimize_error_return branch from 46f887e to a7b554f Compare May 30, 2024 08:40
@Iceber Iceber changed the title chroes: optimizing the error returns in the seataserver controller chores: optimizing the error returns in the seataserver controller May 30, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the conflict needs to be dealt with.

@Iceber Iceber force-pushed the optimize_error_return branch from a7b554f to 20a70be Compare June 13, 2024 05:57
@Iceber Iceber requested a review from slievrly June 13, 2024 05:58
Copy link

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants