Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch is not protected against accidental pushes. #130

Open
raiden00pl opened this issue Feb 19, 2025 · 5 comments
Open

Master branch is not protected against accidental pushes. #130

raiden00pl opened this issue Feb 19, 2025 · 5 comments

Comments

@raiden00pl
Copy link
Member

raiden00pl commented Feb 19, 2025

I just accidentally pushed to the master branch and it worked. Is this how it should be?

shouldn't this be set for the master branch here? @cederom @lupyuen @acassis @jerpelea

Image
@cederom
Copy link
Contributor

cederom commented Feb 19, 2025

Still the issue? I have no admin on the repo.. maybe @jerpelea @acassis ?

@raiden00pl
Copy link
Member Author

I think only Apache INFRA can access to repo settings.

@cederom
Copy link
Contributor

cederom commented Feb 20, 2025

@hartmannathan could you please verify all our repos settings so direct push is NOT allowed or know anyone who can ? :-)

Update: now -> NOT, hanks @hartmannathan =)

@hartmannathan
Copy link
Contributor

@cederom I assume you mean so direct push is NOT allowed :-) I will ask Infra to fix this in all our repos.

@hartmannathan
Copy link
Contributor

@cederom Infra replied fast! Turns out this is something we can do ourselves. See: https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branchpro -- it looks slightly involved and I don't have time to study it right away. Should I ask for help on the dev list or is it something you feel comfortable doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants