-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP-221: Make TableView support TTL #18229
Comments
@Demogorgon314 It's a little confusing if the TTL can only apply to the table view that is based on the non-persistent topic. Or can it also apply to the persistent topic? And the TTL is based on the message publish time or the time arrive the consumer. |
@codelipenghui I have changed the PIP describe base on your comment. Please take a look again! Thanks. |
@Demogorgon314 LGTM |
I don't think that TTL is related to supporting non-persistent topics. Maybe the TTL feature is worth a PIP, but supporting non-persistent topics is like a small enhancement (or completing the TableView) feature to me and it doesn't need a PIP, as it doesn't need API changes |
@eolivelli Yes, I can change this PIP title to |
Discussion Email Thread: https://lists.apache.org/thread/jq8dr965vqox52f5n6h9jt2npnwkxrfn |
The issue had no activity for 30 days, mark with Stale label. |
@Demogorgon314 Should we close this PIP if we decide not to work on this? |
Motivation
Currently, the table view only supports removing messages
when receiving tombstone messages.
However, some old keys may be useless after a while,
but we won't be able to remove them unless we manually scan the map.
Like load data in PIP-192 #16691.
This PIP will introduce the TTL to delete the old data,
and the TTL will be based on the message publish time.
Goal
Add TTL for persistent and non-persistent topic data in the table view.
API Changes
Implementation
The data can be stored in a caffeine cache.
We can easily use
expireAfter
API to add TTL support.Alternatives
Users manually maintain another cache to scan
and remove it by tombstone messages.
Anything else?
No response
The text was updated successfully, but these errors were encountered: