[fix][CI] Follow-up fix for don't run "Pulsar CI checks completed" too early #17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nicoloboschi
approved these changes
Sep 12, 2022
… too early - another solution is needed to make it work as expected
lhotari
force-pushed
the
lh-fix-pulsar-ci-2nd-attempt
branch
from
1c2c0e4 to
bab43df
Compare
|
docs for "needs" context: https://docs.github.com/en/actions/learn-github-actions/contexts#needs-context thanks to @tisonkun for pointing out the solution in #17584 (comment) |
tisonkun
approved these changes
Sep 12, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The "Pulsar CI checks completed" gets run too early also with [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image #17584 changes
another solution is needed to make it work as expected
Modifications
if: always()and a solution where each required build is checked explicitly in a bash script. If the requirements aren't fulfilled, the script will fail with error code 1.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)