Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][bugfix] Fix set-persistence parameters #17955

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

ddieruf
Copy link
Contributor

@ddieruf ddieruf commented Oct 6, 2022

Fixes #xyz

Master Issue: #xyz

Motivation

The example in the documentation will send the namespace into an endless loop waiting for ack. The number ack's should be relative to the number of bookies.

Modifications

Reverse the param values to make ack's less that # of bookies.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@ddieruf Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-label-missing doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Oct 6, 2022
@ddieruf ddieruf changed the title Fix set-persistence parameters [docs][bugfix] Fix set-persistence parameters Oct 6, 2022
Copy link
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you David

@dave2wave dave2wave merged commit 36e5ae5 into apache:master Oct 6, 2022
@ddieruf ddieruf deleted the patch-1 branch October 6, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants