Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] Clarify maven running environments under windows #18373

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

nullscript
Copy link
Contributor

@nullscript nullscript commented Nov 7, 2022

Motivation

I tried to build my Pulsar environment by following README.md, but failed. Because I used Powershell to run maven command line on Windows, maven recognized windows and used rename-netty-native-libs.cmd , powershell can't run cmd. Even I annotate the windows profile, let maven run rename-netty-native-libs.sh on powershell, but there is lacking many Linux commands on Powershell, such as mktemp.
So I think it is better to clarify the command line running environment in windows to reduce misunderstandings.

Modifications

Clarify the maven running environments under windows.
Other minor fixes, e.g. first word capitalization this -> This

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

@nullscript Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Nov 7, 2022
@Anonymitaet
Copy link
Member

@coderzc could you please review this PR from a technical perspective? Thank you!

@nullscript nullscript requested a review from coderzc November 9, 2022 02:31
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @nullscript!

LGTM. Pending for merging...

@tisonkun tisonkun merged commit 8407986 into apache:master Nov 9, 2022
@nullscript
Copy link
Contributor Author

Thanks for reviewing and updating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants