Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] typo in functions-runtime #18976

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

0xflotus
Copy link
Contributor

@0xflotus 0xflotus commented Dec 18, 2022

I only fixed a small typo error

Fixes #xyz

Master Issue: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

I only fixed a small typo error
@github-actions
Copy link

@0xflotus Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@0xflotus 0xflotus changed the title docs: fix small error [doc]: fix small error Dec 18, 2022
@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Dec 18, 2022
@nodece nodece requested a review from momo-jun December 19, 2022 09:20
@tisonkun tisonkun changed the title [doc]: fix small error [fix][doc] typo in functions-runtime Dec 19, 2022
@tisonkun tisonkun merged commit feb3cb4 into apache:master Dec 19, 2022
@tisonkun
Copy link
Member

tisonkun commented Dec 19, 2022

Thanks for your contribution @0xflotus!

@momo-jun momo-jun added this to the 2.11.0 milestone Dec 20, 2022
@0xflotus 0xflotus deleted the patch-1 branch December 20, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants