[fix][broker] Topic could be in fenced state forever if deletion fails #19129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
type/bug
eolivelli
approved these changes
Jan 4, 2023
| @@ -1289,6 +1289,11 @@ public void deleteLedgerComplete(Object ctx) { | |||
| }); | |||
|
|
|||
| return deleteFuture; | |||
| }).whenComplete((value, ex) -> { | |||
There was a problem hiding this comment.
nit: you could use 'exceptionally'
There was a problem hiding this comment.
exceptionally swallows the exception so it's not a good fit here
| }).whenComplete((value, ex) -> { | ||
| if (ex != null) { | ||
| unfenceTopicToResume(); | ||
| log.error("[{}] Error deleting topic", topic, ex); |
There was a problem hiding this comment.
It is better to log before calling unfenceTopicToResume
HQebupt
approved these changes
Jan 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #19129 +/- ##
============================================
+ Coverage 46.35% 47.51% +1.15%
- Complexity 8939 10755 +1816
============================================
Files 597 712 +115
Lines 56858 69650 +12792
Branches 5905 7481 +1576
============================================
+ Hits 26357 33094 +6737
- Misses 27616 32842 +5226
- Partials 2885 3714 +829
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eolivelli
approved these changes
Jan 4, 2023
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Jan 4, 2023
apache#19129) (cherry picked from commit a6516a8)
@nicoloboschi I see the partitioned metadata update when topic deleted is introduced by #18193 that does not cherry-pick to branch-2.10. So this PR neither needs to cherry-pick to branch2.10, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's blind spot in the topic deletion where, if an exception occurs during the partitioned metadata update, the topic ends in a fenced state and it can't be deleted or used. With a broker restarts, the topic is deletable again. However the topic might be in an inconsistent state.
Modifications
FaultInjectionMetadataStoreto be usable also from the MetadataCache methodsVerifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete