Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][txn] Use MLTransactionMetadataStore in integration tests #19140

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

nicoloboschi
Copy link
Contributor

Motivation

Transaction's integration tests use the in memory implementation for the txn metadata store.
Since they're very important test to ensure stability of the transactions feature, it's better to use the default store which is actually designed to run in production environments.

Modifications

  • Do not set InMemTransactionMetadataStoreProvider in the integration tests setup

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codelipenghui codelipenghui added this to the 2.12.0 milestone Jan 6, 2023
@codelipenghui codelipenghui added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Jan 6, 2023
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #19140 (f8e48e1) into master (4b8f447) will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19140      +/-   ##
============================================
+ Coverage     47.00%   47.65%   +0.65%     
+ Complexity    10639     9582    -1057     
============================================
  Files           713      633      -80     
  Lines         69672    59867    -9805     
  Branches       7482     6236    -1246     
============================================
- Hits          32746    28531    -4215     
+ Misses        33212    28249    -4963     
+ Partials       3714     3087     -627     
Flag Coverage Δ
unittests 47.65% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
...apache/pulsar/broker/service/TopicListService.java 10.40% <0.00%> (-30.40%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 61.73% <0.00%> (-11.74%) ⬇️
...balance/impl/SimpleResourceAllocationPolicies.java 48.57% <0.00%> (-5.72%) ⬇️
.../pulsar/broker/service/BrokerServiceException.java 45.45% <0.00%> (-5.46%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 73.75% <0.00%> (-3.75%) ⬇️
...va/org/apache/pulsar/broker/service/ServerCnx.java 45.92% <0.00%> (-2.25%) ⬇️
...ice/persistent/PersistentMessageExpiryMonitor.java 43.75% <0.00%> (-1.05%) ⬇️
...oker/service/schema/SchemaRegistryServiceImpl.java 65.60% <0.00%> (-0.58%) ⬇️
...ava/org/apache/pulsar/broker/service/Producer.java 58.90% <0.00%> (-0.55%) ⬇️
... and 117 more

@nicoloboschi nicoloboschi merged commit 6335fa1 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants