[fix][client] thread-safe seek #20321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc1764f.
tisonkun
force-pushed
the
fix-seek-async-another-way
branch
3 times, most recently
from
d4a60dd to
d1f93e6
Compare
Technoboy-
reviewed
May 15, 2023
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
fix-seek-async-another-way
branch
from
d1f93e6 to
40b7665
Compare
Technoboy-
approved these changes
May 15, 2023
14 tasks
|
Rebase and merged. |
15 tasks
|
The commit title does not contain the number of this PR number, but it is also valid, so cherry-picked into
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #20242.
Please review in commits. If it's accepted, please merge by
rebase and mergeso that we can pick the second commit without style changes.Motivation
Revert unrelated style changes and use
IllegalStateExceptionoverCancellationException.Modifications
AS DESCRIBED MOVE.
Verifying this change
testSeekAsyncInternalDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: