Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService #20372

Merged
merged 1 commit into from
May 23, 2023
Merged

[fix][broker] Change some static fields referencing mutable objects to ordinary instance fields in BrokerService #20372

merged 1 commit into from
May 23, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 23, 2023

Motivation

Mutable objects shouldn't be static fields in BrokerService

Modifications

Drop static definition and make them ordinary instance fields.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
[fix][broker] Change some static fields referencing mutable objects t…
17cffa0 
…o ordinary instance fields in BrokerService

Mutable objects shouldn't be static fields in BrokerService
@lhotari lhotari added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label May 23, 2023
@lhotari lhotari added this to the 3.1.0 milestone May 23, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 23, 2023
eolivelli
eolivelli approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

good catch !

@lhotari
Copy link
Member Author

lhotari commented May 23, 2023

/pulsarbot rerun-failure-checks

@lhotari
Copy link
Member Author

lhotari commented May 23, 2023

/pulsarbot rerun-failure-checks

@merlimat merlimat merged commit e008de9 into apache:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@eolivelli eolivelli eolivelli approved these changes

@nodece nodece nodece approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees
No one assigned
Labels
doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lhotari @merlimat @eolivelli @nodece @nicoloboschi @michaeljmarshall