[improve][broker] Log warning on missing URL configuration for cluster creation/update #20541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
requested review from
nodece,
tisonkun,
michaeljmarshall and
mattisonchao
nodece
reviewed
Jun 19, 2023
nodece
requested changes
Jun 19, 2023
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterDataImpl.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Jun 19, 2023
|
/pulsarbot run-failure-checks |
|
Thanks for your contribution! I'm checking this patch now. Please revert the format only changes (whitespace) so that we narrow the conflict possibility. |
|
@tisonkun sure, will get on it now 👍🏻 |
|
@tisonkun should've just commited and told you 😅 . Done! |
tisonkun
approved these changes
Jun 20, 2023
…-message-when-URL-verification-fails-for-cluster-creation
|
/pulsarbot run-failure-checks |
|
Merging... Thank you! |
2 tasks
JooHyukKim
deleted the
19866-log-warning-message-when-URL-verification-fails-for-cluster-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #19866
Motivation
As proposed in #19866 (comment), warning message can be provided on existence of URL verification fails.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: