Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 733: Event Time support in java client #734

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

sijie
Copy link
Member

@sijie sijie commented Aug 31, 2017

Motivation

Introduce event_time in message for use cases (e.g. stream computing) that needs event time.

This change is part of #732

Modifications

  • add event_time field in message metadata proto
  • expose setEventTime in MessageBuilder
  • expose getEventTime in Message
  • add event_time test cases for message & message builder

Result

After this change, clients are able to set and get event time from messages.

- add `event_time` field in message metadata proto
- expose `setEventTime` in MessageBuilder
- expose `getEventTime` in Message
- add event_time test cases for message & message builder
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added this to the 1.20.0-incubating milestone Aug 31, 2017
@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Aug 31, 2017
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 070ebc0 into apache:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants