Issue #735: Event Time support in c++ client #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Aug 31, 2017
| @@ -71,6 +71,11 @@ class MessageBuilder { | |||
| MessageBuilder& setPartitionKey(const std::string& partitionKey); | |||
|
|
|||
| /** | |||
| * Set the event timestamp for the message. | |||
| */ | |||
| MessageBuilder& setEventTimestamp(uint64_t event_timestamp); | |||
There was a problem hiding this comment.
Nitpick: in C++ code we've been using camelCase for classes and var names, like eventTimestamp
merlimat
added
the
type/feature
|
@merlimat cool. I was following the protobuf code convention. I just changed |
jai1
reviewed
Aug 31, 2017
| @@ -73,9 +73,26 @@ | |||
| */ | |||
| MessageId getMessageId(); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Java changes in C++ Client PR?
There was a problem hiding this comment.
Alternately just merge the JAva PR and the difference won't be seen in this PR.
There was a problem hiding this comment.
Agreed, but I think you will still need to rebase this PR.
This change is adding `event-time` support in c++ and python client. It is based on the change of apache#733
jai1
approved these changes
Aug 31, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of #732 - adding event time setter and getter in both c++ and python client.