New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Disable copy and assign from another value, but allow move" #2521

Closed

alexeyr opened this issue Jan 29, 2019 · 2 comments

Labels

status: help wanted

Contributor

alexeyr commented Jan 29, 2019 •

edited

Loading

This is the comment at https://github.com/dmlc/tvm/blob/1120655b7bc43c8881f982424a986974eeaf75e6/include/tvm/runtime/packed_func.h#L609-L612, but instead of being disabled the copy constructor is declared on the next line (and the assignment operator on https://github.com/dmlc/tvm/blob/1120655b7bc43c8881f982424a986974eeaf75e6/include/tvm/runtime/packed_func.h#L718-L720).

One of them should be removed, but I don't know which (deleting copy constructor explicitly makes compilation fail).

Member

tqchen commented Jan 30, 2019

Thanks for pointing it out. The comment should be removed

tqchen added the status: help wanted label

alexeyr mentioned this issue

Remove an obsolete comment #2527

Merged

Member

tqchen commented Jan 30, 2019

close by #2527 thanks to @alexeyr

tqchen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment