Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select light/dark theme variant depending on Riot's theme setting #38

Open
6 tasks
aperezdc opened this issue Jan 23, 2017 · 1 comment
Open
6 tasks
Assignees

Comments

@aperezdc
Copy link
Owner

Riot has not a dark theme variant (element-hq/element-web#1635). It would be desirable that the GTK+ theme variant being used follows the user setting in Riot. This will be a little bit involved, as we would like to pick the user setting from Riot's preferences, which means:

  • Adding a WebKitWebExtension to gain access to the DOM, or using an injected JS snippet plus user script messages (see WebKitUserContentManager).
  • Listen for onclick events on the radio buttons used to select the theme.
    • On logout, we probably want to revert to the default (light) theme.
    • When Riot finishes loading, we check what is the selected variant, and apply it to the GTK+ theme variant selection if needed.
    • Also, remember the choice as a GSetting so Revolt does not initially start with a different theme variant than that used by Riot.
  • Once this is done, it could be that running inside the Flatpak sandbox still triggers issue Dark GTK+ theme is not used when running in the Flatpak sandbox #11. Double check that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants