-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import system not working #90
Comments
I am getting the same / similar problem. My error is: My setup: Any help on this appreciated as it's stopping our entire development. This is the first time I've used VDS, so it'd also be great to know if it's perhaps a misunderstanding with the docs? Thanks. |
Hey folks! Just returned from a 5 week “offline” trip, hence the little delay here. Let me get back to this early next week when I’ve survived the jet lag :) |
@dracon @michaelpumo Could you please share how you’re trying to import the system? In package.json, you should have something like this if testing locally:
and later, in your main.js:
|
@viljamis That’s exactly how I was doing it. I’ve tried both a Vue Cli project and a Nuxt one. |
@michaelpumo Just tested creating a new project with the latest vue-cli + building and installing a new local library package with Vue Design System 3.0.1. Everything seems to be working for me, so would you mind sharing the exact steps & code you’re using? (and additionally testing if this is fixed with 3.0.1) |
@viljamis @michaelpumo This is how I did: (CWD = ~/coding/)
(CWD = ~/coding/some-design-system)
(CWD = ~/coding/some-design-system) (CWD = ~/coding/vds-hello-world) (CWD = ~/coding/vds-hello-world) ...
import SDS from 'some-design-system'
import 'some-design-system/dist/system.css'
...
Vue.use(SDS)
new Vue( ... (CWD = ~/coding/vds-hello-world) <template>
<div id="app">
<img src="./assets/logo.png">
<HelloWorld msg="Welcome to Your Vue.js App"/>
<Heading level="h1">Hello from your Design-System-Component</Heading> <--- VDS-Component
</div>
</template> (CWD = ~/coding/vds-hello-world) |
@alpadev thank you for these steps. @michaelpumo did you manage to get it sorted out? |
I think I actually now know what the issue is here and we might have to switch away from Webpack for the library build. See my comment here: #91 (comment) |
Please see if you can get your lib working inside this setup, Vue CLI is currently causing some issues that need to be resolved: https://github.com/viljamis/vue-design-system-example. One big issue being that Vue Design System can’t be currently imported to a project using Vue 2.5.17+ due to some breaking changes they’ve introduced, so you need to use 2.5.16 or below for now. This will get hopefully fixed later on. |
@dracon @michaelpumo This is now fixed and releasing a new version soon with the fix. if you’re still, even after the latest version seeing this error, it’s probably caused by the fact that you’re trying to import the provided UMD module as an ES Module. |
Just released a new version with a fix for this: https://github.com/viljamis/vue-design-system/releases/tag/3.5.2 (see the demo links and instructions under them) |
Thanks for vue-design-system. It's amazing.
I tried to import system in a existing Vue-project as mentioned on "getting startet" as local npm package
But I get this error:
13:8-14 "export 'default' (imported as 'system') was not found in 'wb-design-system'
I'm using @vue/cli 3.* and if I take a look inside system.js I can see there are exports,system ...
I'm really confused.
I hope to get help here because I didn't find help anywhere else.
The text was updated successfully, but these errors were encountered: