Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the background control #741

Closed
aristath opened this issue Mar 18, 2016 · 7 comments
Closed

Rebuild the background control #741

aristath opened this issue Mar 18, 2016 · 7 comments
Labels
Milestone

Comments

@aristath
Copy link
Contributor

The current implementation is pretty horrible...
Something like this would make more sense: https://github.com/devinsays/customizer-background-control

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@hellor0bot
Copy link

This would be a great feature!

@Rayken
Copy link

Rayken commented Apr 18, 2016

+1 for this!

I would like to see it allowing a background color though, so maybe making the image optional? Otherwise it might be more logical to name it "background image control" rather than "background control"!

Edit: This would be lovely to use in repeaters as well! Having to use multiple dropdowns and radios to do the same thing at the moment.

@rahulv3a
Copy link

+1

@robbisy
Copy link

robbisy commented Apr 21, 2016

aristath it's kind of a funny you talks about devin's background control cause when he develop this stuff he talked about your background control here

@aristath
Copy link
Contributor Author

@robbisy Yeah, I know... but there's no denying his control is way better-coded than the one included in Kirki!!
I have decided to implement a new background control that will save the values in an array, so we'll avoid creating a bunch of separate theme_mods or options.
The only issue is backwards-compatibility, which will be taken care of as explained on #952 (comment)
It's just gonna take some more time but it's the right way to do it. 😄

@hellor0bot
Copy link

Will this be happening in 2.4?

@aristath
Copy link
Contributor Author

Booya!
Nailed it. :)
Version 3.0 includes a new background control.
May need some improvements in the UI, but otherwise 100% functional. closing this one.

@aristath aristath added this to the 3.0 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants