Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

modules: Added a hello world and slightly improved the Docker one #15

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

Miouyouyou
Copy link
Member

The new "Hello World" module should help people understand the minimum requirements.

Note that these requirements will still change over time, given that the architecture is still
in alpha stage.

That said, having an overview module should help attracting developers more quickly than
a lengthy documentation.

On the docker side, the dependencies have been slightly improved, but that's actually
a part of the architecture I'll have to revise, since one "DEPS" file is not enough for all
the various ubuntu and debian versions.
I still wonder if I'm going to mimic the 'config/...' folder architecture used for the installer,
or if I'll try to shorten it with things like DEPS.debian.12 DEPS.ubuntu.2204 ...

Also, the menu now works correctly on the Docker UI (yay...) and a button was added
to this menu to open the docker-compose installation folder.
The module architecture is still lacking a way to provide "debian-install.sh" files, and
this is one of the priority for the next merges.
Without that, there's no way to provided the folders required by the module.

@Miouyouyou Miouyouyou self-assigned this Jun 27, 2022
This example should help people developing modules
quickly understand the minimum structure required.

Signed-off-by: Myy Miouyouyou <[email protected]>
Added the ability to check the logs of running instances.

I'm still worried about running background processes with UI,
like "checking the logs continuously" or
"checking the status continuously", since it's the kind of
process that can hog a machine quickly, if they're not handled
correctly when they're not needed.

So, at the moment, I'll just add a few more buttons in order
to check things manually.

Also, docker-compose provide no clear way of checking the
status of an installation. You can use 'ps', and you'll know
the status of each invididual service.
However, it's then up to you to determine if the status of
each service makes sense.

Signed-off-by: Myy Miouyouyou <[email protected]>
@Miouyouyou
Copy link
Member Author

Also adding that the hello world module should close #14

Copy link
Contributor

@TheLinuxBug TheLinuxBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell. Will approve but may still request Igor or Lane to complete a more comprehensive code review

@igorpecovnik igorpecovnik merged commit 860ee67 into armbian:main Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants