Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config option to new value #1

Merged
merged 2 commits into from
May 23, 2017
Merged

Update config option to new value #1

merged 2 commits into from
May 23, 2017

Conversation

look
Copy link
Contributor

@look look commented May 21, 2017

As of CommonMarker 0.14.5, all the symbol names have been capitalized. This
updates the code to use the latest version of commonmarker and fix the symbol
names in #render_html and #render_doc.

See: gjtorikian/commonmarker#36

As of CommonMarker 0.14.5, all the symbol names have been capitalized. This
updates the code to use the latest version of commonmarker and fix the symbol
names in #render_html and #render_doc.

See: gjtorikian/commonmarker#36
@arokettu
Copy link
Owner

@look Thank you. Good catch. Only one thing — if the trouble is for 0.14.5 and later then version constraint should also be >= 0.14.5. Don't restrict working versions

@look
Copy link
Contributor Author

look commented May 23, 2017

@sandfoxme OK, sure. I've updated it to be less restrictive. I went with 0.16.0 originally because that's what I tested it with.

@arokettu arokettu merged commit bcbc07c into arokettu:master May 23, 2017
@arokettu
Copy link
Owner

Ok, thank you. I'll test it and release a new version asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants