-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GetMediaInformation Function to fail with response #20
Comments
There is also a |
So what I was seeing is it was never getting past the getInformation command in Swift. Unless the URL was valid and then it would go on as normal and I could use MediaInformationSession. |
Well, there is not much we can do about it. When the URL is not valid My suggestion is to use the asynchronous |
Ok thanks, I just saw there is also GetMediaInformation withTimeout. Will setting a timeout say of 1 second cause it to fail if the URL does not respond? |
No, it won't. That timeout is for something else. You're free to try but it shouldn't change anything. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is your feature request related to a problem? Please describe.
When using FFprobeKit.getMediaInformation(url) it seems to only work if the url is valid. Which prevents subsequent code from being executed, by getting stuck.
Describe the solution you'd like
It would be useful if it provided a ReturnCode as the FFmpegKit provides. This way you know if the media information request failed and if so why. Or at a minimum, it could return nil if it fails.
Describe alternatives you've considered
I have added my own check before I execute GetMediaInformation. I check to see if I can hit the URL and get a response before trying the GetMediaInformation.
Platform
I'm currently experiencing the issue in Swift on tvOS but I would guess it would be a cross-platform issue.
Additional context
The text was updated successfully, but these errors were encountered: