Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin test script is failing - CI badges missing #943

Closed
janpieper opened this issue Jan 10, 2024 · 3 comments
Closed

plugin test script is failing - CI badges missing #943

janpieper opened this issue Jan 10, 2024 · 3 comments
Assignees
Labels

Comments

@janpieper
Copy link
Contributor

janpieper commented Jan 10, 2024

Describe the Bug

The CI badges in the README have been removed by 15dadb1, but scripts/test_plugin.bash is still looking for them, which causes the CI to fail.

For example, see #942.

Steps to Reproduce

Just examples:

$ ./scripts/test_plugin.bash --file plugins/elixir
FAIL: Expected plugin CI badge SVG to be passing but it was not:
$ ./scripts/test_plugin.bash --file plugins/erlang
FAIL: Expected plugin CI badge SVG to be passing but it was not:

Expected Behaviour

The scripts/test_plugin.bash should not check the badge anymore.

Actual Behaviour

The scripts/test_plugin.bash is failing, because the CI badges are missing.

Environment

🤷

$ asdf-info
asdf-info: command not found
@janpieper janpieper added the bug label Jan 10, 2024
This was referenced Jan 10, 2024
@jthegedus
Copy link
Contributor

is still looking for them, which causes the CI to fail.

Too right! I was going to make some further updates to this but GitHub went down 🙃

Will look to get this fixed shortly.

@jthegedus jthegedus self-assigned this Jan 10, 2024
@jthegedus
Copy link
Contributor

Ah, you beat me too it! thanks!

@jthegedus
Copy link
Contributor

Closed in #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants