[red-knot] Port 'deferred annotations' unit tests to Markdown #15686
+55
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
sharkdp
commented
Jan 23, 2025
| @@ -6080,29 +6079,6 @@ mod tests { | |||
| assert_diagnostic_messages(diagnostics, expected); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn resolve_method() -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
Removed without replacement.
sharkdp
commented
Jan 23, 2025
| } | ||
|
|
||
| #[test] | ||
| fn local_inference() -> anyhow::Result<()> { |
There was a problem hiding this comment.
Removed without replacement.
This comment was marked as resolved.
This comment was marked as resolved.
AlexWaygood
approved these changes
Jan 23, 2025
crates/red_knot_python_semantic/resources/mdtest/annotations/deferred.md
Outdated
Show resolved
Hide resolved
sharkdp
force-pushed
the
david/mdtest-custom-typeshed
branch
from
f1e6aaa to
49fc7ce
Compare
sharkdp
force-pushed
the
david/port-deferred-annotations-tests
branch
from
c513ba8 to
2022245
Compare
dcreager
added a commit
that referenced
this pull request
Jan 24, 2025
* main: [red-knot] MDTests: Do not depend on precise public-symbol type inference (#15691) [red-knot] Make `infer.rs` unit tests independent of public symbol inference (#15690) Tidy knot CLI tests (#15685) [red-knot] Port comprehension tests to Markdown (#15688) Create Unknown rule diagnostics with a source range (#15648) [red-knot] Port 'deferred annotations' unit tests to Markdown (#15686) [red-knot] Support custom typeshed Markdown tests (#15683) Don't run the linter ecosystem check on PRs that only touch red-knot crates (#15687) Add `rules` table to configuration (#15645) [red-knot] Make `Diagnostic::file` optional (#15640) [red-knot] Add test for nested attribute access (#15684) [red-knot] Anchor relative paths in configurations (#15634) [`pyupgrade`] Handle multiple base classes for PEP 695 generics (`UP046`) (#15659) [`pyflakes`] Treat arguments passed to the `default=` parameter of `TypeVar` as type expressions (`F821`) (#15679) Upgrade zizmor to the latest version in CI (#15649) [`pyupgrade`] Add rules to use PEP 695 generics in classes and functions (`UP046`, `UP047`) (#15565) [red-knot] Ensure a gradual type can always be assigned to itself (#15675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implicit_global_in_functionunit test to Markdownresolve_methodandlocal_inferenceunit tests. These seem like relics from a time where type inference was in it's early stages. There is no way that these tests would fail today without lots of other things going wrong as well.part of #13696
based on #15683
Test Plan
New MD tests for existing Rust unit tests.