Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to constrain universal locks to specific markers #6184

Closed
charliermarsh opened this issue Aug 18, 2024 · 2 comments · Fixed by #6210
Closed

Allow users to constrain universal locks to specific markers #6184

charliermarsh opened this issue Aug 18, 2024 · 2 comments · Fixed by #6210
Assignees
Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

I think we should let users apply a global marker constraint to "universal" resolution. E.g., maybe you don't care about locking on Windows, so you specify platform_system != 'Windows' in your pyproject.toml, and we avoid solving any branches that are Windows-only. Later, when installing, we'd error if the user is on an unsupported platform, based on those markers.

This would (1) make resolution a lot faster for users that only care about certain platforms, (2) enable us to solve locks that legitimately don't have solutions on certain platforms.

This would also solve #4087.

@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality preview Experimental behavior labels Aug 18, 2024
@zanieb
Copy link
Member

zanieb commented Aug 18, 2024

I like it.

@charliermarsh charliermarsh self-assigned this Aug 18, 2024
@BurntSushi
Copy link
Member

I like this a lot. I feel like it's a good release valve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants