Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add unit tests for extra Action impl block #1593

Closed
Lilyjjo opened this issue Sep 30, 2024 · 2 comments
Closed

core: add unit tests for extra Action impl block #1593

Lilyjjo opened this issue Sep 30, 2024 · 2 comments
Labels
closed-stale core pertaining to the astria-core crate stale testing

Comments

@Lilyjjo
Copy link
Contributor

Lilyjjo commented Sep 30, 2024 •
edited by sync-by-unito bot
Loading

We have extra helper methods defined for the Action type that could benefit from having unit tests. At the time of writing the needed unit tests include: as_sequence(), as_transfer(), is_fee_asset_change(), and is_fee_change().

┆Issue Number: ENG-887
@Lilyjjo Lilyjjo added testing core pertaining to the astria-core crate labels Sep 30, 2024
@Lilyjjo Lilyjjo mentioned this issue Sep 30, 2024
Merged
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba
Copy link
Member

This issue was closed because it was stale

@joroshiba joroshiba closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-stale core pertaining to the astria-core crate stale testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joroshiba @Lilyjjo