rebuild helper script does not work with the switch arg

[Ramblurr]

According to the docs, this should work:

nix run .#nixosConfigurations.my-microvm.config.microvm.deploy.rebuild [email protected] [email protected] switch

But when I run this I always get:

$ nix run .#nixosConfigurations.my-microvm.config.microvm.deploy.rebuild root@host root@target switch
Usage: /nix/store/kxrflcsnx1zayqaa389mn9zbfn9c3bby-microvm-rebuild/bin/microvm-rebuild root@<host> root@<target> [--use-remote-sudo] switch

Looking at the code, this makes sense, the conditional wrapping the "Usage" print will always trigger when "switch" is passed.

microvm.nix/nixos-modules/microvm/ssh-deploy.nix

Lines 214 to 240 in d3a9b75

	rebuild = with config.microvm.deploy; pkgs.writeShellScriptBin "microvm-rebuild" ''
	set -eou pipefail
	HOST="$1"
	shift
	TARGET="$1"
	shift
	OPTS="$@"
	if [ $# -gt 0 ]; then
	if [ "$1" == "--use-remote-sudo" ]; then
	OPTS="$1"
	shift
	fi
	fi
	if [[ -z "$HOST" || -z "$TARGET" || $# -gt 0 ]]; then
	echo "Usage: $0 root@<host> root@<target> [--use-remote-sudo] switch"
	exit 1
	fi
	${lib.getExe installOnHost} "$HOST" $OPTS
	${if canSwitchViaSsh
	then ''${lib.getExe sshSwitch} "$TARGET" $OPTS''
	else ''ssh "$HOST" -- systemctl restart "microvm@${hostName}.service"''
	}
	'';
	};
	}

Handling the "switch" isn't implemented AFAICT.

[astro]

Yeah, the arguments handling needs to be revised. IIRC that was the main reason I haven't tagged a stable version in a long time.

[Ramblurr]

Which commands do you want it to support besides switch?

[astro]

build, and --use-remote-sudo but independent of its position

[Ramblurr]

I read in another comment that there are plans to rewrite some scripts in python. Does that include this one? I could submit a PR either in bash or python.

[astro]

bash