Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not take sampleRate input #7

Open
yomed opened this issue Oct 28, 2017 · 2 comments
Open

Does not take sampleRate input #7

yomed opened this issue Oct 28, 2017 · 2 comments

Comments

@yomed
Copy link

yomed commented Oct 28, 2017

In case anyone else runs into this: I noticed that the docs indicate sampleRate input as in new PitchAnalyzer(sampleRate). But in actuality, it appears that the rate of 44100 is hardcoded, and the input is not used.

@apasov
Copy link

apasov commented Nov 10, 2017

Yes, I can confirm that. In my case with 48000 sample rate pitch is not detected properly. I have to resample the audio buffer to 44100 before processing it with pitch.js

@mikemichaelis
Copy link

mikemichaelis commented Jul 5, 2019

why not change the hard coded sample rate to 48000? or change the prototype value before you new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants