Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ownership of the contract: safe transfer of privileges #741

Closed
sept-en opened this issue May 12, 2022 · 0 comments · Fixed by #742
Closed

Upgrade ownership of the contract: safe transfer of privileges #741

sept-en opened this issue May 12, 2022 · 0 comments · Fixed by #742
Assignees

Comments

@sept-en
Copy link
Contributor

sept-en commented May 12, 2022

The AdminControlled.sol contract now utilizes the improved ownership transfer as per #659, nevertheless, it's still possible to upgrade the admin to EOA/contract which doesn't own his key. In order to improve it, acceptAdmin() method should allow only the nominated admin to accept the ownership over the contract. This guarantees the nominated admin has control over his private key by the time of changing ownership of the contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant