Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allocate an O(N) slice of errors when lastErrorOnly is set in Config #23

Closed
amukherj opened this issue Nov 26, 2019 · 1 comment
Closed

Do not allocate an O(N) slice of errors when lastErrorOnly is set in Config #23

amukherj opened this issue Nov 26, 2019 · 1 comment

Comments

@amukherj
Copy link
Contributor

If the caller isn't interested in the entire history of errors, then he shouldn't have to pay for it in memory cost.
@amukherj amukherj mentioned this issue Nov 26, 2019
Merged
@JaSei
Copy link
Collaborator

JaSei commented Nov 27, 2019

fixed in version 2.4.3 (#22)

@JaSei JaSei closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amukherj @JaSei