Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed README error for custom OEmbed modals #525

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

thijskuilman
Copy link
Contributor

@thijskuilman thijskuilman commented Dec 19, 2024

The readme states that you have to use the default name filament_tiptap_grid when you want to overwrite the OEmbed Modal. This is an error: you should use the filament_tiptap_oembed default name instead:

class OEmbedAction extends Action
{
    public static function getDefaultName(): ?string
    {
        return 'filament_tiptap_oembed';
    }
    ...

I updated the readme to fix this instruction.

@awcodes awcodes merged commit 372dad4 into awcodes:3.x Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants