Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snapp to URL Shortner #1084

Closed
wants to merge 5 commits into from
Closed

Add Snapp to URL Shortner #1084

wants to merge 5 commits into from

Conversation

Ki-er
Copy link
Collaborator

@Ki-er Ki-er commented Jan 4, 2025

Closes #818

Install instructions - https://github.com/urania-dev/snapp?tab=readme-ov-file#getting-started

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@Ki-er Ki-er added addition Adding new software to the list reviewers wanted Awaiting reviews labels Jan 4, 2025
TheGiraffe3
TheGiraffe3 reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem that there are any published releases for this project, although there are four tags.
Does that violate the guidelines?

@Ki-er @TheGiraffe3
Update software/snapp.yml
2374b7a 
Co-authored-by: Loymdayddaud <[email protected]>
@Ki-er
Copy link
Collaborator Author

Ki-er commented Jan 5, 2025

Releases can be found here: https://github.com/urania-dev/snapp/releases

TheGiraffe3
TheGiraffe3 approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, all pre-releases. That makes sense, I guess.

Rabenherz112
Rabenherz112 reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@Rabenherz112 Rabenherz112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to include this project now, given that it's still in the pre-release stage? Previously, we to hold off on including projects labeled as "work in progress," "undergoing a rewrite," or similar. Should we take the same approach here?

@kokomo123
Copy link
Collaborator

kokomo123 commented Jan 19, 2025 •
edited
Loading

We could take the same approach here, and reopen when the maintainer eventually gives it an actual 'release' tag, should we check back in assuming May 19th, 2025? If that's fine with everyone else, I am open to doing different ways though.

@nodiscc
Copy link
Member

nodiscc commented Jan 19, 2025

Let's wait until a final release is made, and not marked as Pre-release

@nodiscc nodiscc closed this Jan 19, 2025
@nodiscc nodiscc added needs to mature Project is younger than 4 months and removed reviewers wanted Awaiting reviews labels Jan 19, 2025
@Ki-er Ki-er deleted the add-snappli branch January 28, 2025 22:36
@Ki-er Ki-er mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rabenherz112 Rabenherz112 Rabenherz112 left review comments

@TheGiraffe3 TheGiraffe3 TheGiraffe3 approved these changes

Assignees
No one assigned
Labels
addition Adding new software to the list needs to mature Project is younger than 4 months
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Snapp.li
5 participants
@Ki-er @kokomo123 @nodiscc @Rabenherz112 @TheGiraffe3