Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handle form input on Android-Web #4292

Merged

Conversation

DanielMuller
Copy link
Contributor

Addresses issue #3598

Description of changes:
On Android-Web, v-model is not updated with keyboards using IME, unless a space is typed as described in vuejs/vue#8231 and vuejs/vue#8723
Which leads to this.signInUsername to stay empty in components/authenticator/SignIn.vue

Adding v-on:input as suggested by vuejs/vue#8231 (comment) fixes the issue for Android-Web without any impact on Desktop.

Tested on Chrome-Android and Chrome Desktop.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #4292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4292   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         165      165           
  Lines        9032     9032           
  Branches     1820     1820           
=======================================
  Hits         7110     7110           
  Misses       1789     1789           
  Partials      133      133
Impacted Files Coverage Δ
...vue/src/components/authenticator/UsernameField.vue 57.14% <ø> (ø) ⬆️
...fy-vue/src/components/authenticator/PhoneField.vue 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b2ea6...4a2aa20. Read the comment docs.

Copy link
Contributor

@jordanranz jordanranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for contributing!

@jordanranz jordanranz merged commit f9e7b1b into aws-amplify:master Oct 31, 2019
Amplifiyer pushed a commit to Amplifiyer/amplify-js that referenced this pull request Nov 1, 2019
@DanielMuller DanielMuller deleted the fix-vuejs-androidweb-login branch November 6, 2019 06:53
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants