RFC: 0110 framework/cli compatibility assurance #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
suggested changes
Feb 3, 2020
RomainMuller
reviewed
Feb 3, 2020
|
@eladb @RomainMuller This is ready for another review. I think the main issues to address are: Thanks |
iliapolo
commented
Feb 4, 2020
eladb
changed the title
eladb
suggested changes
Feb 4, 2020
There was a problem hiding this comment.
The current proposal does fully address the problem of a new framework version that requires a new CLI version as it still leaves quite a lot of potential for error by developers:
- They can forget to write an integ test
- The bump of the protocol version can be messed up (happened many times)
Let's take this all the way and just eliminate one direction of compatibility by requiring CLI to always be >= framework. We already push users to upgrade their CLIs and already have cases where this is required (even if users don't use a new feature), so let's just keep it dead simple.
eladb
reviewed
Feb 4, 2020
rix0rrr
reviewed
Feb 5, 2020
eladb
changed the title
iliapolo
force-pushed
the
epolon/compatibility-strategy
branch
from
380a98a to
947ba44
Compare
iliapolo
commented
Feb 15, 2020
This was referenced Mar 2, 2020
eladb
approved these changes
Mar 18, 2020
RomainMuller
approved these changes
Mar 18, 2020
…k-rfcs into epolon/compatibility-strategy
|
@eladb @RomainMuller @rix0rrr I made the adjustments according to the new schema versioning we implemented. Have a quick look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered version
Closes #110
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license