Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Gamelift L2 Construct RFC #436 documentation #445

Merged
merged 13 commits into from
Sep 20, 2022

Conversation

stevehouel
Copy link
Contributor

This is a request for comments about Amazon Gamelift L2 Construct. See #436 for
additional details.

APIs are signed off by @otaviomacedo.


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

- Using declarative style through constructor properties
- Add asset static methods for Build
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass. One general request that I have is that it would be nice to see all the code first without methods (like withQueue()). I think seeing all the options in the constructor makes it easier to reason about.

@mergify mergify bot dismissed corymhall’s stale review August 23, 2022 13:16

Pull request has been modified.

otaviomacedo
otaviomacedo previously approved these changes Sep 20, 2022
@mergify mergify bot dismissed otaviomacedo’s stale review September 20, 2022 09:57

Pull request has been modified.

@otaviomacedo otaviomacedo merged commit 1c26e74 into aws:master Sep 20, 2022
@stevehouel stevehouel deleted the houes/rfc-436 branch December 4, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants