Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-eks): Allow custom parameters for cluster creation #11872

Closed
1 of 2 tasks
iliapolo opened this issue Dec 4, 2020 · 1 comment
Closed
1 of 2 tasks

(aws-eks): Allow custom parameters for cluster creation #11872

iliapolo opened this issue Dec 4, 2020 · 1 comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@iliapolo
Copy link
Contributor

iliapolo commented Dec 4, 2020

We should allow users to pass additional parameters to the createCluster operation that the custom resources invokes.

Use Case

Normally, when some properties are missing from the implementation of an L2 construct, we refer customers to the escape hatching mechanism, allowing them to add those properties to the underlying CFN resource.

In our case, we are not using the L1 CFN construct, which means this mechanism is essentially void. We should implement an escape hatch that easily lets users augment the parameters we pass the SDK call.

This will allow users to implement missing features in the library.

For example:

Proposed Solution

Make sure the custom resources can pass through custom properties configured on the underlying AWS::Custom resource.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@iliapolo iliapolo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2020
@iliapolo iliapolo added this to the [GA] @aws-cdk/aws-eks milestone Dec 4, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 4, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2020
@iliapolo iliapolo removed this from the [GA] @aws-cdk/aws-eks milestone Dec 25, 2020
@iliapolo iliapolo removed their assignment Jun 27, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 28, 2022
@github-actions github-actions bot closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

1 participant