Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions-tasks): support parameters in StepFunctionsInvokeActivity #21077

Merged
merged 6 commits into from
Jul 12, 2022
Merged

feat(stepfunctions-tasks): support parameters in StepFunctionsInvokeActivity #21077

merged 6 commits into from
Jul 12, 2022

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jul 10, 2022

Fixes #21020

This PR adds the parameters to the StepFunctionsInvokeActivity class.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 10, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 10, 2022 08:30
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 10, 2022
@mrgrain mrgrain self-assigned this Jul 11, 2022
mrgrain
mrgrain previously requested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daschaa and thanks for your contribution! This looks like it's on the right way. I've requested two improvements. Let me know what you think!

@mergify mergify bot dismissed mrgrain’s stale review July 11, 2022 19:43

Pull request has been modified.

@daschaa
Copy link
Contributor Author

daschaa commented Jul 12, 2022

@mrgrain I've added the suggestion :)

@mrgrain
Copy link
Contributor

mrgrain commented Jul 12, 2022

@mrgrain I've added the suggestion :)

Great stuff! I think you'll need to updated the integration test snapshots to make the test pass again. Otherwise I'm happy with this.

mrgrain
mrgrain previously approved these changes Jul 12, 2022
View reviewed changes
@mergify mergify bot dismissed mrgrain’s stale review July 12, 2022 17:01

Pull request has been modified.

@daschaa
Copy link
Contributor Author

daschaa commented Jul 12, 2022

@mrgrain I've added the suggestion :)

Great stuff! I think you'll need to updated the integration test snapshots to make the test pass again. Otherwise I'm happy with this.

Done! Thanks for your feedback :)

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e8b2816
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 10f8821 into aws:main Jul 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@daschaa daschaa deleted the stepfunctions_parameters branch July 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

@mrgrain mrgrain

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(stepfunctions-tasks): support parameters in StepFunctionsInvokeActivity
3 participants
@daschaa @mrgrain @aws-cdk-automation