Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-gamelift-alpha: minSize and maxSize don't work #28359

Open
wintersieck opened this issue Dec 14, 2023 · 2 comments
Open

aws-gamelift-alpha: minSize and maxSize don't work #28359

wintersieck opened this issue Dec 14, 2023 · 2 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. p2

Comments

@wintersieck
Copy link

Describe the bug

Setting minSize and maxSize on BuildFleet don't seem to take effect. Example:

const fleet = new gamelift.BuildFleet(this, "Game server fleet", {
  fleetName: id,
  content: build,
  instanceType: ec2.InstanceType.of(
    ec2.InstanceClass.R5,
    ec2.InstanceSize.LARGE
  ),
  desiredCapacity: 1,
  minSize: 1,
  maxSize: 2,
  runtimeConfiguration: {
    serverProcesses: [
      {
        launchPath: "/local/game/GameServer",
        concurrentExecutions: 4,
      },
    ],
  },
});

When deployed, they don't take effect when viewed in the console:

Screenshot 2023-12-13 171232

Expected Behavior

minSize and maxSize should work.

Current Behavior

minSize and maxSize don't effect anything when deployed.

Reproduction Steps

See example above.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.101.1

Framework Version

No response

Node.js Version

v20.8.1

OS

Ubuntu (WSL2 on Windows 11)

Language

TypeScript

Language Version

5.2.2

Other information

No response

@wintersieck wintersieck added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 14, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 14, 2023
@pahud
Copy link
Contributor

pahud commented Dec 14, 2023

Interesting. Can you check the min property value in the template from cdk synth?

As far as I can tell from here, it should be correctly passed to cloudformation?

minSize: props.minSize ? props.minSize : 0,

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 14, 2023
@wintersieck
Copy link
Author

I had the same thought when I glanced at it (it sure looks right!). Interestingly, the template does show the correct values:

$ cdk synth <stackName> | grep Size
      MaxSize: 2
      MinSize: 1

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. p2
Projects
None yet
Development

No branches or pull requests

2 participants