aws-stepfunctions-tasks: EcsRunTask is not actually a construct?

[julianskartor]

Describe the bug

EcsRunTask implements IConstruct even though to my understanding it's not actually a construct (that's my understanding from reading design guidelines as well as the user guide) as it does not represent a CloudFormation resource definition.

Expected Behavior

EcsRunTask does not implement IConstruct.

Current Behavior

EcsRunTask implements IConstruct.

Reproduction Steps

Library API.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

N/A

Framework Version

2.118.0

Node.js Version

N/A

OS

N/A

Language

TypeScript

Language Version

N/A

Other information

No response

[pahud]

EcsRunTask is actually a Construct which implements IConstruct.

Can you elaborate on why it should not?

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[julianskartor]

EcsRunTask is actually a Construct which implements IConstruct.

Can you elaborate on why it should not?

@pahud Reading the cdk design guidelines, the cdk constructs module and the cdk user guide, EcsRunTask (or any of the state machine state types for that matter) does not seem to fulfill the definition of a CDK "construct". In particular, it does not represent a CloudFormation resource definition.

Some highlights:

from design guidelines:

The AWS Construct Library has multiple layers of constructs, beginning with low-level constructs, which we call CFN Resources (short for CloudFormation resources), or L1 (short for "level 1"). These constructs directly represent all resources available in AWS CloudFormation.

from the constructs module's overview:

Constructs are often used to represent the desired state of cloud applications. For example, in the AWS CDK, which is used to define the desired state for AWS infrastructure using CloudFormation, the lowest-level construct represents a resource definition in a CloudFormation template. These resources are composed to represent higher-level logical units of a cloud application, etc.

from IConstruct's documentation:

Represents a construct.

[pahud]

A Construct does not necessary to be a cloudformation resource.

EcsRunTask extends sfn.TaskStateBase, which extends State, which extends Construct so EcsRunTask is technically a Construct.

[julianskartor]

A Construct does not necessary to be a cloudformation resource.

As far as I can find, and as I've pointed out above, a Construct do always represent a CloudFormation resource. If the definition of "Construct" as it is used in the CDK library is different from how it is defined in CloudFormation, the CDK documentation for Construct should specify this.

I know this is a minor detail... But I do think it's technically incorrect given by the current documentation.