Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): cannot upgrade version of clusters with an explicit name #6064

Merged
merged 7 commits into from
Mar 10, 2020

Conversation

moatazelmasry2
Copy link
Contributor

@moatazelmasry2 moatazelmasry2 commented Feb 3, 2020

Fixes #6060

Steps to verify:

  1. Create an EKS Cluster version 1.13
  2. Change the version to 1.14 and apply
  3. Get the error that an update cannot take place because ClusterCreationRole is not allowed to do an eks:UpdateClusterVersion on arn:aws:eks:xxxx:xxx:cluster/xxxx/update
  4. Apply this PR and retry
  5. Updating the cluster works!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@moatazelmasry2 moatazelmasry2 changed the title Allow EKS to upograde Allow EKS to upgrade Feb 3, 2020
@moatazelmasry2 moatazelmasry2 force-pushed the cannot-update-eks-cluster branch from abc90f8 to ac02bd0 Compare February 3, 2020 11:10
@moatazelmasry2 moatazelmasry2 changed the title Allow EKS to upgrade fix(eks): Allow EKS to upgrade Feb 3, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(eks): Allow EKS to upgrade fix(eks): cannot upgrade version of EKS cluster Feb 3, 2020
@eladb
Copy link
Contributor

eladb commented Feb 3, 2020

Thanks, this looks great. Test expectations should be updated.

@moatazelmasry2
Copy link
Contributor Author

moatazelmasry2 commented Feb 3, 2020

Test expectations should be updated.

Thanks but I didn't understand the last part. Should I change/add something?

@eladb
Copy link
Contributor

eladb commented Feb 4, 2020

@moatazelmasry2 wrote:

Thanks but I didn't understand the last part. Should I change/add something?

If you run yarn test, tests will fail and you will need to fix them.

@eladb
Copy link
Contributor

eladb commented Feb 10, 2020

@moatazelmasry2 any updates here? Can I help?

@moatazelmasry2
Copy link
Contributor Author

@eladb thanks, sorry didn't have much time for that yet and still a total ts/cdk noob here. Will try to finally get this thing compiling today and we will see then. Will let you know

@moatazelmasry2 moatazelmasry2 force-pushed the cannot-update-eks-cluster branch from ac02bd0 to f784935 Compare February 11, 2020 09:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 61c1d94
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 86895b2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d1dacdb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb
Copy link
Contributor

eladb commented Mar 9, 2020

Hey, FYI, I've consolidated all integ tests of EKS into a single test so this should be easier to move forward here. Just run "yarn integ" and wait 30 minutes...

eladb
eladb previously approved these changes Mar 10, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some updates and I think this is ready

@mergify mergify bot dismissed eladb’s stale review March 10, 2020 10:36

Pull request has been modified.

@eladb eladb changed the title fix(eks): cannot upgrade version of EKS cluster fix(eks): cannot upgrade version of clusters with an explicit name Mar 10, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b2029ba
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b777f5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] Cannot update EKS Version
3 participants