-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): cannot upgrade version of clusters with an explicit name #6064
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
abc90f8
to
ac02bd0
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thanks, this looks great. Test expectations should be updated. |
Thanks but I didn't understand the last part. Should I change/add something? |
@moatazelmasry2 wrote:
If you run |
@moatazelmasry2 any updates here? Can I help? |
…n order to do an eks stack update
@eladb thanks, sorry didn't have much time for that yet and still a total ts/cdk noob here. Will try to finally get this thing compiling today and we will see then. Will let you know |
ac02bd0
to
f784935
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hey, FYI, I've consolidated all integ tests of EKS into a single test so this should be easier to move forward here. Just run "yarn integ" and wait 30 minutes... |
also update test expectations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some updates and I think this is ready
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #6060
Steps to verify:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license