fix(cli): codepipeline cross account action fails writing output artifacts #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting outputArtifacts
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NetaNir
added
pr/do-not-merge
rix0rrr
reviewed
Mar 5, 2020
| @@ -337,7 +337,8 @@ | |||
| "s3:GetObject*", "s3:GetBucket*", | |||
| "s3:List*", "s3:Abort*", | |||
| "s3:DeleteObject*", "s3:PutObject*", | |||
| "kms:Decrypt", "kms:DescribeKey" | |||
| "kms:Decrypt", "kms:DescribeKey", "kms:Encrypt", | |||
There was a problem hiding this comment.
I would like the reasons we add each of these permissions to be documented somewhere in-line. Can you think of a good place? (Unfortunately JSON doesn't allow comments... Sids?)
The policy you quoted gives the role access to the key VIA S3, but the failing call in CloudTrail said the call was performed directly by CodePipeline (hence the policy denied it). No idea why that would be different. Maybe that's because there's a cross-account bucket access involved? |
NetaNir
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Mar 9, 2020
eladb
pushed a commit
that referenced
this pull request
Mar 9, 2020
…iting outputArtifacts (#6594) To allow cross account actions in codepipeline we create a role in the other account which is assumable by codepipeline. Since the artifacts are stored in an encrypted S3 bucket in the code pipeline account, the role in the other account must have permission to access the bucket and KMS key in the codepipeline account. To give the role permissions to access the bucket and key two type of policies are required: 1. The policy defined on the bucket and key must give the other account permissions to perform all required actions. 2. The role policy must allow all required actions Policy **1** is defined by the codepipeline construct. The role in the other account is created via the (new) bootstrap command and is defined as `DeploymentActionRole` in the `bootstrap-template.json` file. To satisfy **2**, the policy attached to the role must allow the required S3 and KMS actions. The policy attached to the role was missing the required KMS actions to allow writing the output artifacts to the S3 bucket. This commits adds `kms:Encrypt`, `kms:ReEncrypt `, `kms:GenerateDataKey ` to the `DeploymentActionRole` attached policy
horsmand
pushed a commit
to horsmand/aws-cdk
that referenced
this pull request
Mar 9, 2020
…iting outputArtifacts (aws#6594) To allow cross account actions in codepipeline we create a role in the other account which is assumable by codepipeline. Since the artifacts are stored in an encrypted S3 bucket in the code pipeline account, the role in the other account must have permission to access the bucket and KMS key in the codepipeline account. To give the role permissions to access the bucket and key two type of policies are required: 1. The policy defined on the bucket and key must give the other account permissions to perform all required actions. 2. The role policy must allow all required actions Policy **1** is defined by the codepipeline construct. The role in the other account is created via the (new) bootstrap command and is defined as `DeploymentActionRole` in the `bootstrap-template.json` file. To satisfy **2**, the policy attached to the role must allow the required S3 and KMS actions. The policy attached to the role was missing the required KMS actions to allow writing the output artifacts to the S3 bucket. This commits adds `kms:Encrypt`, `kms:ReEncrypt `, `kms:GenerateDataKey ` to the `DeploymentActionRole` attached policy
rix0rrr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…iting outputArtifacts (#6594) To allow cross account actions in codepipeline we create a role in the other account which is assumable by codepipeline. Since the artifacts are stored in an encrypted S3 bucket in the code pipeline account, the role in the other account must have permission to access the bucket and KMS key in the codepipeline account. To give the role permissions to access the bucket and key two type of policies are required: 1. The policy defined on the bucket and key must give the other account permissions to perform all required actions. 2. The role policy must allow all required actions Policy **1** is defined by the codepipeline construct. The role in the other account is created via the (new) bootstrap command and is defined as `DeploymentActionRole` in the `bootstrap-template.json` file. To satisfy **2**, the policy attached to the role must allow the required S3 and KMS actions. The policy attached to the role was missing the required KMS actions to allow writing the output artifacts to the S3 bucket. This commits adds `kms:Encrypt`, `kms:ReEncrypt `, `kms:GenerateDataKey ` to the `DeploymentActionRole` attached policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow cross account actions in codepipeline we create a role in the other account which is assumable by codepipeline. Since the artifacts are stored in an encrypted S3 bucket in the code pipeline account, the role in the other account must have permission to access the bucket and KMS key in the codepipeline account. To give the role permissions to access the bucket and key two type of policies are required:
Policy 1 is defined by the codepipeline construct.
The role in the other account is created via the (new) bootstrap command and is defined as
DeploymentActionRolein thebootstrap-template.jsonfile. To satisfy 2, the policy attached to the role must allow the required S3 and KMS actions. The policy attached to the role was missing the required KMS actions to allow writing the output artifacts to the S3 bucket. This commits addskms:Encrypt,kms:ReEncrypt,kms:GenerateDataKeyto theDeploymentActionRoleattached policyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license